- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
bpo-46105: Honor spec when generating requirement specs with urls and extras #30151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    a5af814    to
    ec6cb9a      
    Compare
  
    db6494c    to
    09add11      
    Compare
  
    09add11    to
    09d890e      
    Compare
  
    | Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. | 
| Sorry, @jaraco, I could not cleanly backport this to  | 
| GH-30156 is a backport of this pull request to the 3.10 branch. | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Dec 16, 2021 
    
    
      
  
    
      
    
  
… extras. (pythonGH-30151) (cherry picked from commit 109d966) Co-authored-by: Jason R. Coombs <[email protected]>
    
  miss-islington 
      added a commit
      that referenced
      this pull request
    
      Dec 16, 2021 
    
    
      
  
    
      
    
  
… extras. (GH-30151) (cherry picked from commit 109d966) Co-authored-by: Jason R. Coombs <[email protected]>
    
  jaraco 
      added a commit
      that referenced
      this pull request
    
      Dec 16, 2021 
    
    
      
  
    
      
    
  
…ls and extras. (GH-30151). (cherry picked from commit 109d966) Co-authored-by: Jason R. Coombs <[email protected]>
| GH-30157 is a backport of this pull request to the 3.9 branch. | 
    
  jaraco 
      added a commit
      that referenced
      this pull request
    
      Dec 17, 2021 
    
    
      
  
    
      
    
  
…ls and extras. (GH-30151). (cherry picked from commit 109d966) Co-authored-by: Jason R. Coombs <[email protected]>
    
  jaraco 
      added a commit
      that referenced
      this pull request
    
      Dec 17, 2021 
    
    
      
  
    
      
    
  
…ls and extras. (GH-30151). (GH-30157) (cherry picked from commit 109d966) Co-authored-by: Jason R. Coombs <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
https://bugs.python.org/issue46105