Skip to content

bpo-40280: Address more test failures on Emscripten (GH-31050) #31050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 5, 2022
Merged

bpo-40280: Address more test failures on Emscripten (GH-31050) #31050

merged 9 commits into from
Feb 5, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Feb 1, 2022 •
edited by bedevere-bot
Loading

Fix wasm32-emscripten test failures and platform issues.

  • Disable syscalls that are not supported or don't work, e.g.
    wait, getrusage, prlimit, mkfifo, mknod, setres[gu]id, setgroups.
  • Use fd_count to cound open fds.
  • Add more checks for subprocess and fork.
  • Add workarounds for missing _multiprocessing and failing socket.accept()
  • Enable bzip2 again
  • Disable large file support
  • Disable signal.alarm for now

https://bugs.python.org/issue40280

@tiran tiran marked this pull request as ready for review February 1, 2022 14:14
@tiran tiran force-pushed the bpo-40280-more-test-fixes branch from e9d6e24 to b34c808 Compare February 1, 2022 16:02
@brettcannon brettcannon self-requested a review February 1, 2022 19:17
brettcannon
brettcannon approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are about recording the known bugs in emscripten and musl so we can easily track when they are fixed.

Tools/wasm/README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bugs?

Tools/wasm/README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added links to bpo and emscripten bug tracker.

@tiran tiran force-pushed the bpo-40280-more-test-fixes branch from c00edf3 to 5f29e63 Compare February 5, 2022 16:32
@tiran
Copy link
Member Author

tiran commented Feb 5, 2022

Thanks for the review!

@tiran
Copy link
Member Author

tiran commented Feb 5, 2022

The failing Windows test is covered by GH-31146

@tiran tiran changed the title bpo-40280: Address more test failures on Emscripten bpo-40280: Address more test failures on Emscripten (GH-31050) Feb 5, 2022
@tiran tiran merged commit 96b344c into python:main Feb 5, 2022
@tiran tiran deleted the bpo-40280-more-test-fixes branch February 5, 2022 19:52
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot