Skip to content

Conversation

@JelleZijlstra
Copy link
Member

Co-authored-by: Jelle Zijlstra [email protected]
Co-authored-by: Éric [email protected].
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri [email protected]

…1429)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
This method, if implemented, will be called by the parent
:class:`OpenerDirector`. It should return a file-like object as described in
the return value of the :meth:`open` of :class:`OpenerDirector`, or ``None``.
the return value of the :meth:`~OpenerDirector.open` method of :class:`OpenerDirector`, or ``None``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not related to this PR, but if some item is mentioned multiple times in one paragrafph, I prefer to keep link only in one of them (usually at the first occurrence). :class:`!OpenerDirector` or ``OpenerDirector``. Too many duplicated links do not make the text more readable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will keep it in mind for the future.

@JelleZijlstra JelleZijlstra merged commit 92d2615 into python:3.9 May 3, 2022
@JelleZijlstra JelleZijlstra deleted the backport-cc6ae4f-3.9 branch May 3, 2022 12:08
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…1429) (python#92199)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Éric <[email protected]>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants