Use binary file objects with tomli to avoid DeprecationWarning
#10933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomli recently (in 1.2.0) deprecated support for passing file objects opened in text mode to `tomli.load`, which is causing DeprecationWarnings in CI runs (see https://app.travis-ci.com/github/python/mypy/jobs/529150228 for an example). This updates the 2 uses of tomli in mypy to open the toml file in binary mode, and also updates the requirements for tomli to be at least 1.1.0 (because support for binary file objects was added in 1.1.0).
Collaborator
|
Dupe of #10893 I think there's a small amount of controversy on this one. I think @JelleZijlstra 's plan was to monitor pypa/pip#10238 (comment) and do what they do (pradyunsg is a maintainer of both TOML and pip) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomli recently (in 1.2.0) deprecated support for passing file objects opened in text mode to
tomli.load, which is causing DeprecationWarnings in CI runs (see https://app.travis-ci.com/github/python/mypy/jobs/529150228 for an example).This updates the 2 uses of tomli in mypy to open the toml file in binary mode, and also updates the requirements for tomli to be at least 1.1.0 (because support for binary file objects was added in 1.1.0).
Test Plan
I ran the tests for the test files that previously caused DeprecationWarnings with tomli 1.2.0 installed and confirmed that there were no DeprecationWarnings.