Skip to content

Follow PEP 673 instead of PEP 484 when dealing with implicit self #14712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Follow PEP 673 instead of PEP 484 when dealing with implicit self #14712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1bf1bf
Follow PEP 673 instead of PEP 484 when dealing with implicit `self`
davfsa Feb 15, 2023
5d8724b
Add missing typehint
davfsa Feb 15, 2023
e1c12f3
Test changes with `setup_self_type`
davfsa Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,11 +972,8 @@ def prepare_method_signature(self, func: FuncDef, info: TypeInfo, has_self_type:
elif isinstance(functype, CallableType):
self_type = get_proper_type(functype.arg_types[0])
if isinstance(self_type, AnyType):
if has_self_type:
assert self.type is not None and self.type.self_type is not None
leading_type: Type = self.type.self_type
else:
leading_type = fill_typevars(info)
self.setup_self_type()
leading_type: Type = info.self_type
if func.is_class or func.name == "__new__":
leading_type = self.class_type(leading_type)
func.type = replace_implicit_first_type(functype, leading_type)
Expand Down
5 changes: 2 additions & 3 deletions test-data/unit/check-selftype.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1692,9 +1692,8 @@ class C:
return self
def baz(self: Self) -> None:
self.x = self
def bad(self) -> None:
# This is unfortunate, but required by PEP 484
self.x = self # E: Incompatible types in assignment (expression has type "C", variable has type "Self")
def eggs(self) -> None:
self.x = self

[case testTypingSelfClashInBodies]
from typing import Self, TypeVar
Expand Down