-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update Unused and __exit__ parameters in stdlib #9519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
Random CI failure, you can re-run just that job |
|
Hmm, while support for arbitrary aliases in flake8-pyi is unrealistic, we could certainly add some special-casing for the |
Are you interested in working on a flake8-pyi PR for this? If not, I can take a look at adding special-casing |
Sure. If I"m stuck I"ll let you know |
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but a few points below! Also, you have a fair few unused noqa comments following the new flake8-pyi release ;)
|
Thanks for looking into the methods I was uncertain about. I still have one unanswered question left:
|
This comment has been minimized.
This comment has been minimized.
Sure, why not! |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Follow up to #9475
Unusedtype alias for unused params.uuid.getnodeby correctly typing an undocumented/unused paramasyncio.runners.Runner.__exit__andsqlite3.dbapi2.Blob.__exit__usingtype[BaseException] | None, BaseException | None, TracebackType | Noneinstead of objects. I couldn't check the source for these two, so I'm not sure if the params are meant to be unsued.There's also 4
object | Nonein stdlib, should I change those toobjectas well?