Add cytoolz.utils.dev_skip_test decorator to skip tests for dev versions
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions. These tests depend on `toolz`, and it is annoying when `toolz` changes in the middle of a PR. Now, the things these tests check for only need to be updated before being uploaded to PyPI.
Member
Author
|
Oops, adding |
It was in `cytoolz.utils`, which added `nose` as a dependency.
Member
Author
|
There is probably a better or builtin way to do this with |
eriknw
added a commit
that referenced
this pull request
May 6, 2014
Add `cytoolz.utils.dev_skip_test` decorator to skip tests for dev versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests depend on
toolz, and it is annoying whentoolzchanges in the middle of a PR. Now, the things these tests check for only need to be updated before being uploaded to PyPI.There isn't a test that tests the functionality of this PR.
nosewas a bit funcy for me, which made such a test a little more difficult than I expected. At present, the method in the PR works for me.If there is a better way to conditionally skip tests, please share!