Skip to content

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Sep 7, 2022

Description

Adding a guideline to build Torch-TensorRT on Windows platform using MS Visual Studio

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@andi4191 andi4191 added component: build system Issues re: Build system channel: windows bugs, questions, & RFEs around Windows labels Sep 7, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 7, 2022
@github-actions github-actions bot requested a review from narendasan September 7, 2022 21:56
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@andi4191 andi4191 self-assigned this Sep 7, 2022
@narendasan narendasan merged commit 00a1f03 into master Sep 8, 2022
@andi4191 andi4191 deleted the anuragd/windows_guideline branch September 8, 2022 21:51
narendasan added a commit that referenced this pull request Sep 9, 2022
* chore: additional options for perf_run tool

Signed-off-by: dperi <[email protected]>

* feat: Add fx2trt backend and revamp current perf utility to accept CLI arguments

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Refactor fx2trt functionality

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Fix fp16 functionality for fx2trt backend

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: refactor

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: minor change

Signed-off-by: Dheeraj Peri <[email protected]>

* refactor: Refactor perf_run and add internal benchmark scripts

Signed-off-by: Dheeraj Peri <[email protected]>

* chore : minor refactor

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Apply precommit tooling

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Fix data loader issues and nox file paths

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: rebase and minor changes

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Fix reporting to a file setting

Signed-off-by: Dheeraj Peri <[email protected]>

* Update lower.py (#1324)

* docs: [Automated] Regenerating documenation for e374eb1

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

* refactor: Refactor testing to use cosine similarity, remove redundancy models and restructuring

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: move to cosine similarity comparison

Signed-off-by: Dheeraj Peri <[email protected]>

* refactor: Refactor nox file testing

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: add missing scripts

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Linter fixes

Signed-off-by: Dheeraj Peri <[email protected]>

* fix!: Fixed Windows compilation failures

Signed-off-by: Anurag Dixit <[email protected]>

* chore: Minor fix

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: use rn18 instead of rn50

Signed-off-by: Dheeraj Peri <[email protected]>

* docs: [Automated] Regenerating documenation for a1a4786

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

* chore: Add cpp tests with cosine sim

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: linter fixes

Signed-off-by: Dheeraj Peri <[email protected]>

* [feat] Add support for argmax and argmin (#1312)

* [feat] Add support for argmax and argmin

Adds support for aten::argmax and aten::argmin.

Fixes # (issue)

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified

* move max.cpp tests to test_max.cpp no functional change

* fix permissions on max.cpp

* docs: [Automated] Regenerating documenation for 9db2852

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

* chore: Deepcopy other objects

Signed-off-by: Dheeraj Peri <[email protected]>

* fix: Fix deepcopy issues of PTQ calibrators

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: linter fixes

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Adding a guideline to build on Windows platform (#1337)

* chore: Adding Windows build guideline

Signed-off-by: Anurag Dixit <[email protected]>

* chore: Fix formatting

Signed-off-by: Anurag Dixit <[email protected]>

Signed-off-by: Anurag Dixit <[email protected]>

* docs: [Automated] Regenerating documenation for 00a1f03

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

* chore: minor fixes

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Linter fixes

Signed-off-by: Dheeraj Peri <[email protected]>

* chore: Linter fixes

Signed-off-by: Dheeraj Peri <[email protected]>

* docs: [Automated] Regenerating documenation for 1efe4b1

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

* docs: [Automated] Regenerating documenation for 10b9ecd

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

* add support for aten::reciprocal(int) (#1308)

* docs: [Automated] Regenerating documenation for 096fd41

Signed-off-by: Torch-TensorRT Github Bot <[email protected]>

Signed-off-by: dperi <[email protected]>
Signed-off-by: Dheeraj Peri <[email protected]>
Signed-off-by: Torch-TensorRT Github Bot <[email protected]>
Signed-off-by: Anurag Dixit <[email protected]>
Co-authored-by: dperi <[email protected]>
Co-authored-by: Dheeraj Peri <[email protected]>
Co-authored-by: Wei <[email protected]>
Co-authored-by: Torch-TensorRT Github Bot <[email protected]>
Co-authored-by: Anurag Dixit <[email protected]>
Co-authored-by: Michael Feliz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: windows bugs, questions, & RFEs around Windows cla signed component: build system Issues re: Build system documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants