[fix] resolve issue for single non-batch index tensor in aten::index #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
peri044
reviewed
Feb 28, 2023
Comment on lines
+1100
to
+1103
| %5 : NoneType = prim::Constant() | ||
| %18 : Tensor?[] = prim::ListConstruct(%5, %index0) | ||
| %19 : Tensor = aten::index(%x.1, %18) | ||
| return (%19))IR"; |
There was a problem hiding this comment.
@mfeliz-cruise Can you let me know the original pytorch code that generated this graph ?
There was a problem hiding this comment.
input_tensor = input_tensor[:, [2, 1, 0], ...]
mfeliz-cruise
requested review from
peri044
and removed request for
narendasan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a single index tensor the aten::index converter previously assumed that this always indexed the batch dimension. Use the adv_idx_indices to find the dimension it actually indexes instead.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: