feat: support aten.amin dynamo converter #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
zewenli98
commented
Nov 30, 2023
Comment on lines
-958
to
-965
| def amax_param_validator(amax_node: Node) -> bool: | ||
| if len(amax_node.args) < 2: | ||
| _LOGGER.debug( | ||
| f"At least two args input and dim should be provided, but only got {len(amax_node.args)} args." | ||
| ) | ||
| return False | ||
|
|
||
| return True |
There was a problem hiding this comment.
According to the schema, this validator seems not necessary.
Closed
gs-olive
reviewed
Nov 30, 2023
zewenli98
force-pushed
the
amin_dynamo_converter
branch
from
25222b8 to
dbfc9e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
aten.amindynamo converterFixes #2493
Type of change
Checklist: