support native int64 as valid datatype #2937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that https://github.com/pytorch/TensorRT/pull/2855/files#diff-97c67f0cea25ec7aa88ca61594d9ad62e9fb575cab3647b079cb718f81308454 is already planned to do relevant changes. |
|
Thanks @HolyWu for pointing out the above. @narendasan would the changes in PR https://github.com/pytorch/TensorRT/pull/2855/files#diff-97c67f0cea25ec7aa88ca61594d9ad62e9fb575cab3647b079cb718f81308454 work or would we have to create a type map for kINT32 to kINT64 in the torchscript path? |
|
Yeah neither of these PRs implements the feature fully since we need to either amend truncation in TorchScript or have a TorchScript specific type map |
|
@apbose going to close this. reopen a new pr with the comprehensive changes if its still needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.