Skip to content

fix: TS test_scaled_dot_product_attention #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: TS test_scaled_dot_product_attention #3117

merged 1 commit into from
Aug 23, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Fixes #3080

The threshold is deleted for now, which makes the tests failed. It will be totally fixed after #3061 gets merged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Aug 23, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: core Issues re: The core compiler labels Aug 23, 2024
@github-actions github-actions bot requested a review from bowang007 August 23, 2024 02:49
@zewenli98 zewenli98 force-pushed the fix_ts_test_scaled_dot_product_attention branch from 318e631 to dcfe042 Compare August 23, 2024 03:04
@zewenli98 zewenli98 merged commit 5a04839 into main Aug 23, 2024
55 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

@bowang007 bowang007 Awaiting requested review from bowang007

Assignees

@zewenli98 zewenli98

Labels
cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] TS test_scaled_dot_product_attention failed
2 participants
@zewenli98 @facebook-github-bot