Skip to content

chore: Adapt CIA ops decomposition handling in upsample converters to torch 2.6 #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2024
Merged

chore: Adapt CIA ops decomposition handling in upsample converters to torch 2.6 #3227

merged 6 commits into from
Oct 22, 2024

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Oct 11, 2024

Description

Fixes #3226

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 11, 2024
@github-actions github-actions bot requested a review from peri044 October 11, 2024 16:06
narendasan
narendasan reviewed Oct 14, 2024
View reviewed changes
@narendasan narendasan requested a review from apbose October 14, 2024 16:09
@lanluo-nvidia
Copy link
Collaborator

Just saw a new update from torch decomp upstream,
We need add that also
from torch._export.utils import _decomp_table_to_post_autograd_aten

lanluo-nvidia
lanluo-nvidia approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit b6ed1c5 into pytorch:main Oct 22, 2024
67 checks passed
@HolyWu HolyWu deleted the fix_upsample branch October 23, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan left review comments

@lanluo-nvidia lanluo-nvidia lanluo-nvidia approved these changes

@peri044 peri044 Awaiting requested review from peri044

@apbose apbose Awaiting requested review from apbose

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Importing torchao first breaks torch_tensorrt.dynamo.compile during run_decompositions

4 participants

@HolyWu @lanluo-nvidia @narendasan @facebook-github-bot