Skip to content

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented Apr 4, 2025

Description

Previously, index_put converter passed all test cases but failed in a corner case where slicing is done using a multi-dimensional tensor together with None (e.g., tensor[None, idx_tensor]). This PR updates the converter to properly handle that case.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 4, 2025
@chohk88 chohk88 requested review from peri044 and apbose April 4, 2025 23:30
@github-actions github-actions bot requested a review from zewenli98 April 4, 2025 23:30
@chohk88 chohk88 self-assigned this Apr 4, 2025
@chohk88 chohk88 closed this Apr 15, 2025
@chohk88
Copy link
Collaborator Author

chohk88 commented Apr 15, 2025

Closing this PR due to an incorrect author. Reopened as #3475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants