Call narrow only for TensorCoreTiledLayout #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1207
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 95b39ae with merge base 0e854ec ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
changed the title
mcr229
approved these changes
Nov 5, 2024
jerryzh168
force-pushed
the
fix_executorch_quant
branch
from
465d445 to
94e8c4d
Compare
Summary: att, previously in pytorch#914 we added narrow op for all layout, the introduced narrow op breaks the pattern for int8 dynamic activation int4 weight quant for executorch, this PR guarded narrow op for tensor core tiled layout only If similar things coming up in the future we can factor this into a proper API for Layout or TensorImpl Test Plan: python test/test_integration.py -k test_export Reviewers: Subscribers: Tasks: Tags:
jerryzh168
force-pushed
the
fix_executorch_quant
branch
from
94e8c4d to
95b39ae
Compare
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
* Call narrow only for TensorCoreTiledLayout only Summary: att, previously in pytorch#914 we added narrow op for all layout, the introduced narrow op breaks the pattern for int8 dynamic activation int4 weight quant for executorch, this PR guarded narrow op for tensor core tiled layout only If similar things coming up in the future we can factor this into a proper API for Layout or TensorImpl Test Plan: python test/test_integration.py -k test_export Reviewers: Subscribers: Tasks: Tags: * enable test * version * skip aoti * version update * skip aoti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att, previously in #914 we added narrow op for all layout, the introduced narrow op breaks the pattern for int8 dynamic activation int4 weight quant for executorch, this PR guarded narrow op for tensor core tiled layout only
If similar things coming up in the future we can factor this into a proper API for Layout or TensorImpl
Test Plan:
python test/test_integration.py -k test_export
Reviewers:
Subscribers:
Tasks:
Tags: