unpin torch to unbreak mac tests #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2198
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8f4f766 with merge base 34f66b6 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
requested review from
Copilot,
digantdesai and
metascroy
and removed request for
digantdesai and
metascroy
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the broken macOS test by updating the nightly torch version used during installation.
- Update the torch nightly version to 2.7.0.dev20250510
- Maintain installation commands for proper dependency setup during tests
Comments suppressed due to low confidence (1)
.github/workflows/torchao_experimental_test.yml:39
- [nitpick] Ensure that the updated torch nightly version is verified to work with the project's test environment, particularly on macOS.
pip install torch==2.7.0.dev20250510 --index-url "https://download.pytorch.org/whl/nightly/cpu" --force-reinstall
gau-nernst
approved these changes
May 12, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* fix broken mac test * Update torchao_experimental_test.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pytorch/ao/actions/runs/14962782163/job/42027402556
Failing lint error is getting fixed here #2197