Skip to content

make dtensor shared test util more generic #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 24, 2025
Merged

make dtensor shared test util more generic #2416

merged 6 commits into from
Jun 24, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Jun 20, 2025 •
edited
Loading

Summary:

Refactoring to make adding MX easier in next PR, no logic change. Specifically:

  • move _test_lowp_mlp_tensor_parallelism_base to shared util file
  • move config generation out of this function to the callsite
  • instead of gating lowp allgather by rowwise flag, gate it by allgather_in_lowp flag

Test Plan:

./test/float8/test_dtensor.sh

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 3 commits June 20, 2025 07:10
@vkuzo
Update
5c23c6b 
[ghstack-poisoned]
@vkuzo
Update
ad2ce62 
[ghstack-poisoned]
@vkuzo
Update
5eb2066 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Jun 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2416

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo vkuzo mentioned this pull request Jun 20, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2025
@vkuzo vkuzo mentioned this pull request Jun 20, 2025
Merged
vkuzo added a commit that referenced this pull request Jun 20, 2025
@vkuzo
make dtensor shared test util more generic
c290d72 
Summary:

Refactoring to make adding MX easier in next PR, no logic change.

Test Plan:

```bash
./test/float8/test_dtensor.sh
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ffe4a3e
ghstack-comment-id: 2991924397
Pull Request resolved: #2416
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jun 20, 2025
@vkuzo vkuzo requested review from danielvegamyhre and drisspg June 20, 2025 19:22
This was referenced Jun 21, 2025
Merged
Merged
vkuzo added 3 commits June 24, 2025 07:17
@vkuzo
Update
42083e2 
[ghstack-poisoned]
@vkuzo
Update
9d171ad 
[ghstack-poisoned]
@vkuzo
Update
3562a5e 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/88/head to main June 24, 2025 14:18
@vkuzo vkuzo merged commit b963540 into main Jun 24, 2025
37 of 48 checks passed
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
@vkuzo @liangel-02
make dtensor shared test util more generic (#2416)
26b9c3d 
* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]

* Update

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drisspg drisspg drisspg approved these changes

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @drisspg @facebook-github-bot