Skip to content

Conversation

103yiran
Copy link

@103yiran 103yiran commented Jun 26, 2025

The dimensions of scale_e8m0_biased and data_lp are not consistent, and the lowest dimension of scale_e8m0_biased is 1.

Copy link

pytorch-bot bot commented Jun 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2446

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025
@vkuzo
Copy link
Contributor

vkuzo commented Jun 26, 2025

could you share what is broken, and ideally add a test?

@vkuzo vkuzo self-requested a review June 26, 2025 15:51
@103yiran
Copy link
Author

could you share what is broken, and ideally add a test?

@vkuzo I found that the dimensions of scale_e8m0_biased and data_lp are not consistent, and the lowest dimension of scale_e8m0_biased is 1.

@vkuzo
Copy link
Contributor

vkuzo commented Jul 8, 2025

hi @103yiran , thanks for the report! I created #2506 to fix this with a test case, will close this PR.

@vkuzo vkuzo closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants