Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

@weiwangmeta
Copy link
Contributor

On a ARM based MacOS, download miniconda, create conda env, install pytorch, and do import pytorch.

@weiwangmeta weiwangmeta requested a review from atalman August 10, 2022 22:53
@weiwangmeta weiwangmeta force-pushed the weiwangmeta/testing_macos_nightly_wheels branch from 5d8ff1e to 8480824 Compare August 17, 2022 00:16
@weiwangmeta
Copy link
Contributor Author

link: pytorch/pytorch#83013

@weiwangmeta weiwangmeta force-pushed the weiwangmeta/testing_macos_nightly_wheels branch 2 times, most recently from ab9b1e6 to fbec713 Compare August 22, 2022 23:37
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though can you please extract as much logic from .yml into .py file (so that other people would not have to duplicate the behaviour)

@weiwangmeta weiwangmeta force-pushed the weiwangmeta/testing_macos_nightly_wheels branch from db8eb5a to b661426 Compare August 31, 2022 18:19
@weiwangmeta weiwangmeta force-pushed the weiwangmeta/testing_macos_nightly_wheels branch from 1745d9e to bea4236 Compare August 31, 2022 22:29
@weiwangmeta weiwangmeta changed the title [WIP] Testing MacOS release Validation Automation Testing MacOS release Validation Automation Sep 1, 2022
@weiwangmeta
Copy link
Contributor Author

this PR needs to be updated once pytorch/test-infra#654 is merged.

uses: actions/checkout@v3
with:
ref: weiwangmeta/testing_macos_nightly_wheels
- name: Install Fresh Miniconda in Runner Temp Dir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have the setup-miniconda action now from the test-infra repository that should cover this functionality

@weiwangmeta
Copy link
Contributor Author

All comments addressed, please review again, thank you!

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We probably want to align Linux and MacOS jobs by moving composite to actions but can be done in followup PR

@weiwangmeta weiwangmeta merged commit 79a5021 into main Sep 1, 2022
@weiwangmeta weiwangmeta deleted the weiwangmeta/testing_macos_nightly_wheels branch September 22, 2022 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants