Skip to content

Conversation

@metascroy
Copy link
Contributor

_construct_constexpr_dequant_op should use axis = None (default value), rather than -1. This will infer the axis from the shape of scales.

On iOS18, this was not an issue because the axis is not used. For iOS16, the axis is used and the value -1 usually caused an issue during export.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13896

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit fc4e8fe with merge base b02db12 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy
Copy link
Contributor Author

Fixes #13122

@metascroy
Copy link
Contributor Author

FYI to @abhinaykukkadapu. Per-channel 8-bit TorchAO quantization is now supported on iOS16+ with this PR. We can follow up with recipe update.

@jackzhxng
Copy link
Contributor

Passing reminder to use release notes: quantization if you think we should call out this bug fix on the release notes

@metascroy metascroy force-pushed the fix-torchao-quant-for-sub-ios18 branch from 12430d4 to fc4e8fe Compare September 5, 2025 05:12
@metascroy
Copy link
Contributor Author

@cccclai @digantdesai @abhinaykukkadapu @jackzhxng I need a stamp from someone in PyTorch to merge. The Apple engineer has already approved.

@metascroy metascroy merged commit 7e76ba2 into main Sep 5, 2025
120 of 123 checks passed
@metascroy metascroy deleted the fix-torchao-quant-for-sub-ios18 branch September 5, 2025 18:43
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 9, 2025
…tion to IO16

Summary: Following up with recipe update as mentioned here: pytorch#13896 (comment)

Differential Revision: D82048153
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 9, 2025
…tion to IO16 (pytorch#14127)

Summary:

Following up with recipe update as mentioned here: pytorch#13896 (comment)

Reviewed By: metascroy

Differential Revision: D82048153
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 9, 2025
…tion to IO16 (pytorch#14127)

Summary:
Pull Request resolved: pytorch#14127

Following up with recipe update as mentioned here: pytorch#13896 (comment)

Reviewed By: metascroy

Differential Revision: D82048153
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 9, 2025
…tion to IO16 (pytorch#14127)

Summary:

Following up with recipe update as mentioned here: pytorch#13896 (comment)

Reviewed By: metascroy

Differential Revision: D82048153
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 10, 2025
…tion to IO16 (pytorch#14127)

Summary:

Following up with recipe update as mentioned here: pytorch#13896 (comment)

Reviewed By: metascroy

Differential Revision: D82048153
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 10, 2025
…tion to IO16 (pytorch#14127)

Summary:

Following up with recipe update as mentioned here: pytorch#13896 (comment)

Reviewed By: metascroy

Differential Revision: D82048153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants