Add Metal backend build system and runtime integration #15024

manuelcandales · 2025-10-10T21:01:55Z

Build system changes:

Add EXECUTORCH_BUILD_METAL build option in default.cmake
Fix AOTI linker flags for Apple platforms (use -export_dynamic)
Extend AOTI build support to Metal backend
Register Metal backend and configure Metal framework linkage
Add PyTorch AOTI headers and OpenMP library detection with rpath

Runtime implementation:

Add main Metal backend runtime providing entry point for AOTI-compiled
model execution on Metal devices

This commit ties together all Metal backend components and enables
building the complete backend.

[ghstack-poisoned]

manuelcandales · 2025-10-10T21:01:57Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-10-10T21:01:59Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15024

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 74cbeef with merge base 6e0c9f6 ():

CANCELLED JOB - The following job was cancelled. Please retry:

pull (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 32be451 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: dd5866f ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: cde20a4 ghstack-comment-id: 3392300655 Pull-Request: #15024

mergennachin · 2025-10-12T17:55:19Z

backends/apple/metal/CMakeLists.txt

+# It should also be cmake-lint clean.
+#
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
+


cmake_minimum_required(VERSION 3.29)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

if(NOT APPLE)
message(FATAL_ERROR "Metal backend requires macOS")
endif()

mergennachin · 2025-10-12T17:57:56Z

backends/apple/metal/CMakeLists.txt

+         ${METALPERFORMANCESHADERSGRAPH_LIBRARY}
+)
+
+target_compile_options(metal_backend PUBLIC -fexceptions -frtti -fPIC)


Let's remove -frtti and -fexceptions because on desktop, we actually want those, no?

backends/apple/metal/runtime/metal_backend.cpp

mergennachin · 2025-10-12T18:06:31Z

backends/apple/metal/runtime/metal_backend.cpp

+    // Generate dynamic temporary file path
+    filesystem::path temp_dir = filesystem::temp_directory_path();
+    filesystem::path so_path =
+        temp_dir / (so_blob_key + to_string(getpid()) + ".so");
+


do we need to delete these temp files?

backends/apple/metal/runtime/metal_backend.cpp

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: ee5a382 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 6cec8c4 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 47506f2 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: d669c96 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 0c66dd8 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 4051027 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 989b781 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: 086b734 ghstack-comment-id: 3392300655 Pull-Request: #15024

[ghstack-poisoned]

Build system changes: - Add EXECUTORCH_BUILD_METAL build option in default.cmake - Fix AOTI linker flags for Apple platforms (use -export_dynamic) - Extend AOTI build support to Metal backend - Register Metal backend and configure Metal framework linkage - Add PyTorch AOTI headers and OpenMP library detection with rpath Runtime implementation: - Add main Metal backend runtime providing entry point for AOTI-compiled model execution on Metal devices This commit ties together all Metal backend components and enables building the complete backend. ghstack-source-id: b9c5537 ghstack-comment-id: 3392300655 Pull-Request: #15024

Update

b177b63

[ghstack-poisoned]

manuelcandales requested review from cccclai, kirklandsign, larryliu0820 and shoumikhin as code owners October 10, 2025 21:01

manuelcandales requested review from mergennachin and removed request for cccclai, kirklandsign and shoumikhin October 10, 2025 21:02

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2025

Update

9779d54

[ghstack-poisoned]

Update

57d9e45

[ghstack-poisoned]

mergennachin reviewed Oct 12, 2025

View reviewed changes

backends/apple/metal/runtime/metal_backend.cpp Outdated Show resolved Hide resolved

Update

fd707f3

[ghstack-poisoned]

Update

00a154e

[ghstack-poisoned]

manuelcandales added the release notes: none Do not include this in the release notes label Oct 13, 2025

Update

f9c8989

[ghstack-poisoned]

Update

b87d5de

[ghstack-poisoned]

Update

404a1b8

[ghstack-poisoned]

Update

3e8648e

[ghstack-poisoned]

Update

23ec80f

[ghstack-poisoned]

Update

79d8fbc

[ghstack-poisoned]

Update

74cbeef

[ghstack-poisoned]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Metal backend build system and runtime integration #15024

Add Metal backend build system and runtime integration #15024

manuelcandales commented Oct 10, 2025

Uh oh!

manuelcandales commented Oct 10, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

mergennachin Oct 12, 2025

Uh oh!

mergennachin Oct 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergennachin Oct 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add Metal backend build system and runtime integration #15024

Are you sure you want to change the base?

Add Metal backend build system and runtime integration #15024

Conversation

manuelcandales commented Oct 10, 2025

Uh oh!

manuelcandales commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15024

❌ 1 Cancelled Job

Uh oh!

mergennachin Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

mergennachin Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergennachin Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

manuelcandales commented Oct 10, 2025 •

edited

Loading

pytorch-bot bot commented Oct 10, 2025 •

edited

Loading