Skip to content

Conversation

StrycekSimon
Copy link
Collaborator

@StrycekSimon StrycekSimon commented Oct 13, 2025

Summary

Unifies implementation of model quantization between executorch_pipeline.py and example aot_neutron_compile.py and introduces documented single function interface.

Test plan

Should be covered by already existing unit tests.

cc @robert-kalmar @JakeStevens @digantdesai

Copy link

pytorch-bot bot commented Oct 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15044

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 5 Unrelated Failures

As of commit fd1a7df with merge base afd98fe (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@StrycekSimon StrycekSimon force-pushed the feature/nxg10272/EIEX-583-unify-quantization-implementation branch from a60e002 to fd1a7df Compare October 13, 2025 12:35
@StrycekSimon
Copy link
Collaborator Author

@pytorchbot label "module: nxp"

@pytorch-bot pytorch-bot bot added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Oct 13, 2025
@StrycekSimon
Copy link
Collaborator Author

Let's wait for a review from one of my colleagues from NXP this time. 😀 In a meantime, I will check the red signals...

@StrycekSimon
Copy link
Collaborator Author

Those failing tests are unrelated to this PR. Also, I noticed the same error messages in other PRs.

@robert-kalmar robert-kalmar added the release notes: nxp Changes to the NXP Neutron backend delegate label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants