Skip to content

Conversation

Ninja91
Copy link
Contributor

@Ninja91 Ninja91 commented Oct 14, 2025

Summary:
This reverts the changes from D84262200 which removed xfails from tests for 16A8W operations (Slice, Cat, Add, Mul, View, Transpose). After landing, these tests are failing in GitHub CI.

Failed test: https://github.com/pytorch/executorch/actions/runs/18439599594/job/52538228881
Differential Revision: D84564694

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@Ninja91 Ninja91 requested a review from digantdesai as a code owner October 14, 2025 01:55
Copy link

pytorch-bot bot commented Oct 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15088

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 37 Pending, 3 Unrelated Failures

As of commit 72660be with merge base 50f96a0 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ci-no-td label Oct 14, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
Copy link

meta-codesync bot commented Oct 14, 2025

@Ninja91 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84564694.

Ninja91 added a commit to Ninja91/executorch that referenced this pull request Oct 14, 2025
…ytorch#15088)

Summary:

This reverts the changes from D84262200 which removed xfails from tests for 16A8W operations (Slice, Cat, Add, Mul, View, Transpose). After landing, these tests are failing in GitHub CI.

Failed test: https://github.com/pytorch/executorch/actions/runs/18439599594/job/52538228881

Differential Revision: D84564694
@Ninja91 Ninja91 requested review from SaoirseARM and gggekov October 14, 2025 02:01
@Ninja91 Ninja91 changed the title Revert D84262200: Updating tests for 16A8W ops which are supported Revert 16A8W ops test update for slice Oct 14, 2025
@Ninja91 Ninja91 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Oct 14, 2025
Ninja91 added a commit to Ninja91/executorch that referenced this pull request Oct 14, 2025
…ytorch#15088)

Summary:

This reverts the changes from D84262200 which removed xfails from tests for 16A8W operations (Slice, Cat, Add, Mul, View, Transpose). After landing, these tests are failing in GitHub CI.

Failed test: https://github.com/pytorch/executorch/actions/runs/18439599594/job/52538228881

Differential Revision: D84564694
…ytorch#15088)

Summary:

This reverts the changes from D84262200 which removed xfails from tests for 16A8W operations (Slice, Cat, Add, Mul, View, Transpose). After landing, these tests are failing in GitHub CI.

Failed test: https://github.com/pytorch/executorch/actions/runs/18439599594/job/52538228881

Differential Revision: D84564694
@zingo
Copy link
Collaborator

zingo commented Oct 14, 2025

MacOS fails unrelated

@zingo zingo added the release notes: none Do not include this in the release notes label Oct 14, 2025
@zingo zingo merged commit 546c680 into pytorch:main Oct 14, 2025
293 of 300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants