Dynamic Shapes #2442
Closed
Dynamic Shapes #2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2442
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 0d9f2bd with merge base ce344bc ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Mar 15, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
from
c388513 to
62cef72
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Mar 15, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
2 times, most recently
from
42fee96 to
2470cbc
Compare
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Mar 15, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai Differential Revision: D54650121
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
kirklandsign
approved these changes
Mar 15, 2024
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Mar 16, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
from
2470cbc to
72e7885
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Apr 10, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
from
9753a84 to
4a801e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Apr 10, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
from
4a801e6 to
8c49122
Compare
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
from
8c49122 to
6890a10
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
kirklandsign
approved these changes
Apr 11, 2024
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
mcr229
force-pushed
the
export-D54650121
branch
from
6890a10 to
110fd07
Compare
Summary: Pull Request resolved: pytorch#2442 Only need to look at tester.py file for the tester changes. Change is from `.run_method().compare_outputs() ` to `.run_method_and_compare_outputs()` now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic. We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes. Reviewed By: digantdesai, kirklandsign Differential Revision: D54650121
mcr229
force-pushed
the
export-D54650121
branch
from
110fd07 to
0d9f2bd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54650121 |
Contributor
|
This pull request has been merged in 65be9b4. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Only need to look at tester.py file for the tester changes.
Change is from
.run_method().compare_outputs()to.run_method_and_compare_outputs()now if Tester is initialized with dynamic inputs, we will generate random dynamic inputs (according to the specification of the dynamic shapes) to run on the model. This allows us to test that the inputs fed into the model can be dynamic.
We ad a num_runs to run_method_and_compare_outputs so that we can choose to run a number of different dynamic inputs with dynamic shapes.
Reviewed By: digantdesai
Differential Revision: D54650121