Extend constant prop pass to work with int/float/etc scalars and fix input specs. #2950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2950
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
hsharma35
force-pushed
the
export-D55891278
branch
from
1dbb47e to
a833aa7
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 10, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Reviewed By: dulinriley Differential Revision: D55891278
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
hsharma35
force-pushed
the
export-D55891278
branch
from
a833aa7 to
3afc0da
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 10, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Differential Revision: D55891278
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
hsharma35
force-pushed
the
export-D55891278
branch
from
3afc0da to
692fc8c
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 11, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Differential Revision: D55891278
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 11, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Differential Revision: D55891278
hsharma35
force-pushed
the
export-D55891278
branch
from
692fc8c to
5750ca8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
angelayi
approved these changes
Apr 11, 2024
hsharma35
force-pushed
the
export-D55891278
branch
from
5750ca8 to
c61e35e
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 11, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Reviewed By: dulinriley Differential Revision: D55891278
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 11, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Reviewed By: dulinriley Differential Revision: D55891278
hsharma35
force-pushed
the
export-D55891278
branch
from
c61e35e to
3a458b4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 11, 2024
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Reviewed By: dulinriley Differential Revision: D55891278
hsharma35
force-pushed
the
export-D55891278
branch
from
3a458b4 to
0110df7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
…input specs. (pytorch#2950) Summary: 1. Cleanup / Refactor constant prop pass. 2. Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str. Nodes of type `Op(constant_tensor, some_int, some_float, some_dtype, ...)` can now be constant propagated. 3. Fix order of input spec to match the expected spec in `ExportGraphSignature` class. parameters->buffers->constants->user_inputs. Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures. Reviewed By: dulinriley Differential Revision: D55891278
hsharma35
force-pushed
the
export-D55891278
branch
from
0110df7 to
8a237e9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55891278 |
Contributor
|
This pull request has been merged in 5ef8427. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cleanup / Refactor constant prop pass.
Enable constant propagation for ops with constant scalar arguments -- int/float/dtype/bool/str.
Nodes of type
Op(constant_tensor, some_int, some_float, some_dtype, ...)can now be constant propagated.Fix order of input spec to match the expected spec in
ExportGraphSignatureclass.parameters->buffers->constants->user_inputs.
Before this diff, input_specs for the newly added constant tensors were appended to graph_signature, which would cause failures whe.
Differential Revision: D55891278