Skip to content

remove duplicate generate_lib_aten target under aten kernel #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove duplicate generate_lib_aten target under aten kernel #2951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/models/llama2/runner/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

def _get_operator_lib(aten = False):
if aten:
return ["//executorch/kernels/aten:generated_lib_aten"]
return ["//executorch/kernels/aten:generated_lib"]
elif runtime.is_oss:
return ["//executorch/kernels/portable:generated_lib", "//executorch/examples/models/llama2/custom_ops:custom_ops"]
else:
Expand Down
15 changes: 0 additions & 15 deletions kernels/aten/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,3 @@ def define_common_targets():
"@EXECUTORCH_CLIENTS",
],
)

# TODO(T149415783): temporarily testing portable kernel "in aten mode" and remove after migration is done
executorch_generated_lib(
name = "generated_lib_aten",
aten_mode = True,
deps = [
":executorch_aten_ops",
],
functions_yaml_target = None,
define_static_targets = True,
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
)
2 changes: 1 addition & 1 deletion shim/xplat/executorch/extension/pybindings/pybindings.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ATEN_MODULE_DEPS = [
# Generated lib for all ATen ops with aten kernel used by models in model inventory
MODELS_ATEN_OPS_ATEN_MODE_GENERATED_LIB = [
"//executorch/kernels/quantized:generated_lib_aten",
"//executorch/kernels/aten:generated_lib_aten",
"//executorch/kernels/aten:generated_lib",
]

def executorch_pybindings(python_module_name, srcs = [], cppdeps = [], visibility = ["//executorch/..."], types = [], compiler_flags = []):
Expand Down