Skip to content

Conversation

chunyuan-w
Copy link
Collaborator

@chunyuan-w chunyuan-w commented Jun 5, 2024

Stack from ghstack (oldest at bottom):

With #124350 landed, it is now suggested in AOTI to turn on freezing on CPU to get better performance.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Copy link

pytorch-bot bot commented Jun 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128010

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d0e1ccc with merge base 901226a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

chunyuan-w added a commit that referenced this pull request Jun 5, 2024
@chunyuan-w chunyuan-w changed the title [AOTI] tutorial: add suggestion to turn on freezing on CPU [AOTI] docs: add suggestion to turn on freezing on CPU Jun 5, 2024
@svekars svekars added the medium Label for medium docathon tasks label Jun 5, 2024
@svekars svekars requested a review from desertfire June 5, 2024 15:13
@svekars svekars added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jun 5, 2024
@chunyuan-w
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@chunyuan-w chunyuan-w added the release notes: intel release notes category label Jun 6, 2024
@svekars svekars added the topic: not user facing topic category label Jun 6, 2024
@svekars
Copy link
Contributor

svekars commented Jun 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_8-test / test

Details for Dev Infra team Raised by workflow job

@svekars
Copy link
Contributor

svekars commented Jun 6, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/chunyuan-w/15/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/128010)

pytorchmergebot pushed a commit that referenced this pull request Jun 6, 2024
@chunyuan-w
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/chunyuan-w/15/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/128010)

pytorchmergebot pushed a commit that referenced this pull request Jun 7, 2024
@chunyuan-w
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
With pytorch#124350 landed, it is now suggested in AOTI to turn on freezing on CPU to get better performance.

Pull Request resolved: pytorch#128010
Approved by: https://github.com/desertfire
@github-actions github-actions bot deleted the gh/chunyuan-w/15/head branch July 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request medium Label for medium docathon tasks Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source release notes: intel release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants