Skip to content

Conversation

ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Sep 10, 2025

Currently, CI is breaking with:

Wednesday 10 September 2025  14:27:33 +0000 (0:00:00.273)       0:16:18.634 *** 
Error: : Task failed: Conditional result (True) was derived from value of type 'str' at "<CLI option '-e'>". Conditionals must have a boolean result.

This is likely because the installed ansible is now on version 2.19.2. The error is documented here. In order to quickly fix it, I have introduced ALLOW_BROKEN_CONDITIONALS=1 environment variable before ansible-playbook executions.

Key Changes:

  • Add allow_broken_conditionals = true to ansible configuration file ansible.cfg

@ysiraichi ysiraichi force-pushed the ysiraichi/ansible-2.19-broken-conditionals branch from dcb8f36 to e01229f Compare September 10, 2025 20:05
@ysiraichi
Copy link
Collaborator Author

Actually, the environment variable name was: ANSIBLE_ALLOW_BROKEN_CONDITIONALS. I read the docs again, and thought it would be better to just add the ansible config to ansible.cfg.

@bhavya01 What do you think?

@bhavya01
Copy link
Collaborator

Actually, the environment variable name was: ANSIBLE_ALLOW_BROKEN_CONDITIONALS. I read the docs again, and thought it would be better to just add the ansible config to ansible.cfg.

@bhavya01 What do you think?

Sounds good!

@ysiraichi Do you think you can fix the failing CPU test? Doesn't have to be this PR. I'll look into updating the tpu runner image

@bhavya01
Copy link
Collaborator

TPU CI is also updated. Rerunning the tests should work now

@ysiraichi ysiraichi force-pushed the ysiraichi/ansible-2.19-broken-conditionals branch from e01229f to 6d3df2d Compare September 11, 2025 13:36
@ysiraichi ysiraichi changed the title Add ALLOW_BROKEN_CONDITIONALS variable before calling ansible-playbook. Set allow_broken_conditionals configuration variable at ansible.cfg. Sep 11, 2025
Copy link
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ysiraichi
Copy link
Collaborator Author

I'm skipping the failing CPU tests.
I have opened an issue for them #9637, and plan to address them next.

@ysiraichi
Copy link
Collaborator Author

@bhavya01 Since you requested a change after approving, you have to approve it once more. Otherwise, I can't merge this PR.

@bhavya01 bhavya01 merged commit 8efa568 into master Sep 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants