Skip to content

fix: Remove mc #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: Remove mc #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0a9e49
fix: mc setup env vars are not set
KShivendu Apr 17, 2024
58d95c5
fix: Remove mc
KShivendu Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/continuous-benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@ jobs:
- uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
- name: Setup CI
run: bash -x tools/setup_ci.sh
- name: Benches
run: |
export HCLOUD_TOKEN=${{ secrets.HCLOUD_TOKEN }}
export GCS_KEY=${{ secrets.GCS_KEY }}
export GCS_SECRET=${{ secrets.GCS_SECRET }}
export POSTGRES_PASSWORD=${{ secrets.POSTGRES_PASSWORD }}
export POSTGRES_HOST=${{ secrets.POSTGRES_HOST }}
bash -x tools/setup_ci.sh

declare -A DATASET_TO_ENGINE
DATASET_TO_ENGINE["laion-small-clip"]="qdrant-continuous-benchmark"
Expand Down
2 changes: 0 additions & 2 deletions tools/run_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ SCRIPT_PATH=$(dirname "$SCRIPT")

bash -x "${SCRIPT_PATH}/run_remote_benchmark.sh"

./mc cp results/* qdrant/vector-search-engines-benchmark/results/ci/qdrant/

# Upload to postgres
# -t sorts by modification time
export SEARCH_RESULTS_FILE=$(ls -t results/*-search-*.json | head -n 1)
Expand Down
6 changes: 0 additions & 6 deletions tools/setup_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,3 @@ wget https://github.com/hetznercloud/cli/releases/download/${HCVERSION}/hcloud-l
tar xzf hcloud-linux-amd64.tar.gz

sudo mv hcloud /usr/local/bin

# Install mc

wget https://dl.min.io/client/mc/release/linux-amd64/mc
chmod +x mc
./mc alias set qdrant https://storage.googleapis.com "${GCS_KEY}" "${GCS_SECRET}"