Skip to content

Conversation

KShivendu
Copy link
Member

@KShivendu KShivendu commented Apr 17, 2024

  • Add mmap support for reading sparse vectors to avoid OOM error in CI

@KShivendu KShivendu changed the title Fix/manual benchmarks feat: Add mmap support for reading sparse vectors to avoid OOM error in CI Apr 17, 2024
@KShivendu
Copy link
Member Author

KShivendu commented Apr 17, 2024

I've tested that this locally and it passed without errors. Need to merge this PR so the image is updated on Dockerhub and we can test on CI that it actually fixes OOM

@tellet-q tellet-q self-requested a review April 17, 2024 11:31
Copy link
Contributor

@tellet-q tellet-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KShivendu KShivendu merged commit a8bcf78 into master Apr 17, 2024
@KShivendu KShivendu deleted the fix/manual-benchmarks branch April 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants