Skip to content

Conversation

filipecosta90
Copy link
Contributor

@KShivendu KShivendu requested a review from tellet-q June 3, 2024 19:44
Copy link
Contributor

@tellet-q tellet-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I need to check why the CI jobs were skipped

@tellet-q tellet-q self-requested a review June 4, 2024 06:27
@KShivendu KShivendu changed the base branch from master to dev June 4, 2024 08:06
@KShivendu KShivendu changed the base branch from dev to master June 4, 2024 08:15
Copy link
Contributor

@tellet-q tellet-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since there was an issue with our CI and benchmark didn't run for this PR, I verified changes in a separate branch, all good: https://github.com/qdrant/vector-db-benchmark/actions/runs/9380141895

@tellet-q tellet-q merged commit 884fda3 into qdrant:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants