Enable indexing while uploading #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to qdrant/qdrant#6325, qdrant/qdrant#6355.
This PR removes code that disables indexing while uploading. Immediate indexing is now enabled unconditionally (i.e. both fordev
andmaster
), so we can compare how incremental indexing improves the situation.This PR changes the logic that disables indexing while uploading, making it configurable.
Old logic:
max_optimization_threads
=0
.I.e. indexing disabled unconditionally.
max_optimization_threads
=100_000
.I.e. start indexing using CPU quota unconditionally.
New logic:
max_optimization_threads
defaults to0
but could be overwritten in JSON.max_optimization_threads
is0
, set it to100_000
.I.e. start indexing if it was disabled, but do not touch if it was not disabled.
In this PR,
max_optimization_threads
is set tonull
(aka qdrants default, aka"auto"
, aka enable indexing using available CPU resources) for configurations that are used in continuous benchmark action:qdrant-all-on-disk-scalar-q
/qdrant-all-on-disk-scalar-q-with-payload
qdrant-continuous-benchmark
/qdrant-continuous-benchmark-with-payload
qdrant-bq-continuous-benchmark
/qdrant-bq-continuous-benchmark-with-payload
For every other configuration, including
qdrant-default
, the behavior is not changed.