Start a new git history or fork the desktop-app as libdbusmenu-lxqt did?

[redtide]

I discovered that the updated version in KSNI has only the DBusMenuExporter class, not also the Importer, so I guess there will be some work to restore the old one and update it to work correctly like the other?

I wonder if it could be better to make a fork of the abandoned version and apply the KSNI changes/fixes on top of it (at least for the exporter class) or start from scratch with it and add the importer later?

[sebholt]

IDK, I just have started looking into the dbusmenu code (history).

[redtide]

OK, so if you agree the answer is to use the original unity8-team old, not archived repository from where the desktop-app account forked it.
This because it looks the same code from where the KSNI repository got the files and then modified, so later apply the (slightly modified) KSNI commits on top of it, plus our own changes.

[sebholt]

Sounds good.

[redtide]

Going on slowly because other things going on at same time. I have some ready changes here and there and extracted the interesting commits out from KSNI, except the one with the importer removal. Want you give a look to patches before to apply?

[sebholt]

Want you give a look to patches before to apply?

Sure, but how?

[redtide]

Like patches.tar.gz but rn I only adapted the spdx one to the current tree and some need to remove some stuff, so this needs more manual intervention (I guess, for example, at least not removing the export macro for the "dll" and where ksni is also involved)

[redtide]

Uploaded

Nice work!

Thank you! Need more work BTW, the CMake Config is not working

I built the library here for Qt5 and Qt6 with a few warnings.

Ah yes, I forgot to remove some moc files.

Should we not build docs as default to reduce dependencies?

Yes, that makes sense.

OK.

If you want to work on something let me know, we can subdivide some task.

I'm fine looking at your good work ;). But seriously, I'm unsure where I can help besides giving a few uneducated comments :).

Shoot! What's wrong?

[sebholt]

Shoot! What's wrong?

Sorry, I didn't feel too well the last days, probably a cold or so.

[redtide]

I was able to build our libSNI with this library, I think I need to set that repo private to be free to make some force push if needed. I did it also on this one with latest commit to be able to make it work after a few tries. It's OK?

[sebholt]

Sure.

[sebholt]

Some issues:

• src/dbusmenuimporter.cpp still contains an unnecessary dbusmenuimporter.moc include that triggers a warning.
• In cmake/DBusMenuQtilitiesConfig.cmake.in we should use @QT_VERSION_MAJOR@ instead of ${QT_VERSION_MAJOR} so
  that it gets replaced by the configure call.

[redtide]

OK, thank you!