Introduce a Hibernate Reactive variant of the Security Jakarta Persistence extension

[michalvavrik]

closes: #23553

[github-actions]

🙈 The PR is closed and the preview is expired.

[michalvavrik]

I just dropped 2 comments and rebased on main, which leads to this CI enforcer failures. I think it's something from main not related and I'll wait with rebase for review (maybe then it will be fixed)

[quarkus-bot]

Failing Jobs - Building 03df5d5

Status	Name	Step	Failures	Logs	Raw logs
✔️	Gradle Tests - JDK 11
⌛	Gradle Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.0.2-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 105 - More details - Source on GitHub

java.lang.NullPointerException
	at io.quarkus.gradle.builder.QuarkusModelBuilderTest.assertProjectModule(QuarkusModelBuilderTest.java:152)
	at io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel(QuarkusModelBuilderTest.java:105)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleDevModel line 49 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.0.2-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleTestModel line 43 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

✖ io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.gradle.devmode.BasicKotlinApplicationModuleDevModeTest.main line 19 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.gradle.devmode.JandexMultiModuleProjectDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

[sberyozkin]

Hi Michal @michalvavrik, All in all, this is a great enhancement, thanks. I was just about to approve, but then I've spotted the package of the JPA support classes has changed, note, in the doc that is updated in this PR, you can also find:

import io.quarkus.security.jpa.Password;
import io.quarkus.security.jpa.Roles;
import io.quarkus.security.jpa.UserDefinition;
import io.quarkus.security.jpa.Username;

but now a common subpackage is added with the security-jpa-common - so I think quarkus-quickstarts/security-jpa-quickstart will fail.

Can we avoid breaking security-jpa applications, how bad would it be if we kept the same package for these classes in security-jpa-common, I'm concerned about the modularization side-effects, but it is not OSGI after all...

If that would be a problem then I'd suggest keeping per-extension specific versions of the above classes - but it would be unfortunate, true... Perhaps, the better idea in this case would be to keep it as it is but mark this PR with a breaking change label

[michalvavrik]

@sberyozkin package didn't change, no breaking change, no worry

[sberyozkin]

@michalvavrik Oops, it did not :-), for some reasons I got the impression it did, so cool, all is good then :-)

[sberyozkin]

@FroMage Steph, if you have some comments to add to this PR, please do

[sberyozkin]

Lets merge now, Steph, let us know if you have some suggestions how to improve it further