Skip to content

JDK-8316304 in JDK 21 introduced a new field accessed through JNI #38100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024
Merged

JDK-8316304 in JDK 21 introduced a new field accessed through JNI #38100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration-tests/main/src/test/resources/image-metrics/23.1/image-metrics.properties
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need files for 24.0 and 24.1 too now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the mechanism is working OKish (we probably still need to relax some diff percentages), so we could indeed start expanding it to more tests and more versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking because we see the QuarkusTestCallbacksITCase.testCallbackContextIsNotFailed test failing with 24.0 too. See: https://github.com/graalvm/mandrel/actions/runs/7242468774/job/19728465877#step:12:688 or more recently here: https://github.com/graalvm/mandrel/actions/runs/7455460280/job/20285177037#step:12:706

Do you know if the 23.1 specific metrics fix, will fix it for 24.0 and 24.1 as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, this PR got merged since it fixes an issue with GraalVM for JDK 21 builds (internal version 23.1). Later releases are still being tracked in #37809.

Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ analysis_results.classes.jni=62
analysis_results.classes.jni.tolerance=1
analysis_results.methods.jni=55
analysis_results.methods.jni.tolerance=1
analysis_results.fields.jni=61
analysis_results.fields.jni.tolerance=1
analysis_results.fields.jni=62
analysis_results.fields.jni.tolerance=2