tarfs: remove ReadFile
#1325
Merged
tarfs: remove ReadFile
#1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradLugo
requested review from
crozzy and
hdonnay
and removed request for
a team
|
I wanted to use this PR to discuss the merits of removing If there is a significant reason to keep |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
- Coverage 56.28% 56.25% -0.04%
==========================================
Files 266 266
Lines 16842 16812 -30
==========================================
- Hits 9480 9458 -22
+ Misses 6398 6391 -7
+ Partials 964 963 -1 ☔ View full report in Codecov by Sentry. |
hdonnay
approved these changes
Jun 12, 2024
Signed-off-by: Brad Lugo <[email protected]>
BradLugo
force-pushed
the
blugo/remove-readfile
branch
from
b631810 to
94e3ee6
Compare
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete removes
ReadFilefromtarfs.Follow up to #1305.