ruby: support gemspec

[RTann]

No description provided.

[RTann]

I can make more tests in a bit, but I wanted to open this up for review anyway

[RTann]

I understand this is pretty large, but I'm not sure a better way to do this. I think we should have a Quay repo we can use for test images

[crozzy]

We could try making use of the fetch.Layer() functionality as we do here: https://github.com/quay/claircore/blob/main/rpm/packagescanner_test.go#L1616. We already have https://quay.io/repository/projectquay/clair-fixtures I can skopeo cp as needed and/give you access to push (if you don't have it).

[crozzy]

Can we do something like this to avoid the inevitable "add a case, forget to Discard"?

func gems(ctx context.Context, sys fs.FS) (out []string, err error) {
	return out, fs.WalkDir(sys, ".", func(p string, d fs.DirEntry, err error) error {
		ev := zlog.Debug(ctx).
			Str("file", p)
		defer func() {
			ev.Discard().Send()
		}()
		switch {
		case err != nil:
			return err
		case !d.Type().IsRegular():
			// Should we chase symlinks with the correct name?
			return nil
		case strings.HasPrefix(filepath.Base(p), ".wh."):
			return nil
		case gemspecPath.MatchString(p):
			ev = ev.Str("kind", "gem")
		default:
			return nil
		}
		ev.Msg("found package")
		out = append(out, p)
		return nil
	})
}

[crozzy]

We could try making use of the fetch.Layer() functionality as we do here: https://github.com/quay/claircore/blob/main/rpm/packagescanner_test.go#L1616. We already have https://quay.io/repository/projectquay/clair-fixtures I can skopeo cp as needed and/give you access to push (if you don't have it).

[hdonnay]

This looks pending a rewrite down to a single commit

[RTann]

This looks pending a rewrite down to a single commit

not sure I follow?

[RTann]

This looks pending a rewrite down to a single commit

oh I misread at first. Thought you said "comment" not "commit". Is that needed? Wouldn't Squash and merge handle that?

[hdonnay]

oh, I suppose it would. It does skip all the commit lints though, so make sure to keep a Signed-off-by trailer and a properly formatted subject line.