Skip to content

QuickPerfSpringRunner did not call the Spring TestExecutionListener instances after the test method execution #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

QuickPerfSpringRunner did not call the Spring TestExecutionListener instances after the test method execution #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...uickPerfSpringRunnerBeforeNewJvmTest.java → ...erfSpringRunnerBeforeAfterNewJvmTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package org.quickperf.spring.springboottest;

import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand All @@ -34,7 +35,7 @@
@Import(QuickPerfSqlConfig.class)
@DataJpaTest()
@DisableGlobalAnnotations
public class QuickPerfSpringRunnerBeforeNewJvmTest {
public class QuickPerfSpringRunnerBeforeAfterNewJvmTest {

@Autowired
private TestEntityManager testEntityManager;
Expand All @@ -55,4 +56,10 @@ public void should_find_all_players() {
assertThat(players).hasSize(3);
}

@After
public void after() {
Player player = new Player();
testEntityManager.persist(player);
}

}
9 changes: 8 additions & 1 deletion ...test/QuickPerfSpringRunnerBeforeTest.java → ...QuickPerfSpringRunnerBeforeAfterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package org.quickperf.spring.springboottest;

import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand All @@ -32,7 +33,7 @@
@Import(QuickPerfSqlConfig.class)
@DataJpaTest()
@DisableGlobalAnnotations
public class QuickPerfSpringRunnerBeforeTest {
public class QuickPerfSpringRunnerBeforeAfterTest {

@Autowired
private TestEntityManager testEntityManager;
Expand All @@ -52,4 +53,10 @@ public void should_find_all_players() {
assertThat(players).hasSize(3);
}

@After
public void after() {
Player player = new Player();
testEntityManager.persist(player);
}

}
4 changes: 2 additions & 2 deletions ...-spring3/src/main/java/org/quickperf/spring/junit4/SpringRunnerWithQuickPerfFeatures.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ public Statement withBefores(FrameworkMethod frameworkMethod, Object testInstanc

@Override
public Statement withAfters(FrameworkMethod frameworkMethod, Object testInstance, Statement statement) {
Statement springAfters = super.withAfters(frameworkMethod, testInstance, statement);
return quickPerfJUnitRunner.withAfters(frameworkMethod, testInstance, springAfters);
Statement quickPerfStatement = quickPerfJUnitRunner.withAfters(frameworkMethod, testInstance, statement);
return super.withAfters(frameworkMethod, testInstance, quickPerfStatement);
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions ...-spring4/src/main/java/org/quickperf/spring/junit4/SpringRunnerWithQuickPerfFeatures.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ public Statement withBefores(FrameworkMethod frameworkMethod, Object testInstanc

@Override
public Statement withAfters(FrameworkMethod frameworkMethod, Object testInstance, Statement statement) {
Statement springAfters = super.withAfters(frameworkMethod, testInstance, statement);
return quickPerfJUnitRunner.withAfters(frameworkMethod, testInstance, springAfters);
Statement quickPerfStatement = quickPerfJUnitRunner.withAfters(frameworkMethod, testInstance, statement);
return super.withAfters(frameworkMethod, testInstance, quickPerfStatement);
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions ...-spring5/src/main/java/org/quickperf/spring/junit4/SpringRunnerWithQuickPerfFeatures.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ public Statement withBefores(FrameworkMethod frameworkMethod, Object testInstanc

@Override
public Statement withAfters(FrameworkMethod frameworkMethod, Object testInstance, Statement statement) {
Statement springAfters = super.withAfters(frameworkMethod, testInstance, statement);
return quickPerfJUnitRunner.withAfters(frameworkMethod, testInstance, springAfters);
Statement quickPerfStatement = quickPerfJUnitRunner.withAfters(frameworkMethod, testInstance, statement);
return super.withAfters(frameworkMethod, testInstance, quickPerfStatement);
}

@Override
Expand Down