This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Migrate more scss to styled components #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deployed to: http://staging.quran.com:32960 |
thabti
reviewed
Oct 2, 2017
| `; | ||
|
|
||
| const disabled = css` | ||
| opacity: 0.5; |
Contributor
There was a problem hiding this comment.
indent, if you use VS Code, it has support for styled-components
Contributor
Author
There was a problem hiding this comment.
I do. Hmm, not sure why didn't indent. Will fix
thabti
approved these changes
Oct 2, 2017
thabti
reviewed
Oct 2, 2017
src/components/SurahInfo/index.js
Outdated
| import React, { PropTypes } from 'react'; | ||
| import * as customPropTypes from 'customPropTypes'; | ||
| import styled from 'styled-components'; | ||
| import { lighten } from 'polish'; |
thabti
suggested changes
Oct 2, 2017
Contributor
thabti
left a comment
thabti
left a comment
There was a problem hiding this comment.
module 'polish' should be 'polished'
Contributor
Author
|
@sabeurthabti good catch. Weird my webpack didn't scream. |
Contributor
Author
|
@sabeurthabti PTAL. Fixed |
thabti
approved these changes
Oct 11, 2017
Contributor
Author
|
rebuild |
Contributor
|
Deployed to: http://staging.quran.com:32962 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Firstly, we have been using a hacky library called
webpack-isomorphic-toolsto get styles working on the server. There are alternatives now, such as getting webpack to serve server files but regardless this is a great opportunity to transition into css-in-js. What's most powerful about it is code-splitting CSS comes for free since it's in the JS bundle. Additionally, we will continue to make more DLS components that are easily customizable thanks to styled-components