Skip to content

Conversation

@mcol
Copy link
Contributor

@mcol mcol commented Oct 17, 2025

This is a small part of #2737 (5 files), which should be manageable to review. If it's not desired, just close it.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (ae6b6a7) to head (c9a4702).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2950   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files         129      129           
  Lines        7276     7276           
=======================================
  Hits         7221     7221           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico
Copy link
Collaborator

Thank you! However, this will conflict with some pending PRs (e.g. #2829), so I'd prefer to avoid generating conflicts if possible. If you want to do the extra legwork to ensure there are no conflicts you can try adapting https://gist.github.com/MichaelChirico/64e981b4359a36d2279bf55c39c7d3dd (script for getting files by PR)

@mcol
Copy link
Contributor Author

mcol commented Oct 17, 2025

Thanks Michael. I've removed changes to files that were touched in any form by PRs opened since January, and gave a cursory glance to older ones (without seeing other conflicts). This is much smaller but better than nothing! :)

Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@MichaelChirico MichaelChirico merged commit aff43f1 into r-lib:main Oct 17, 2025
21 checks passed
@mcol mcol deleted the issue_2737_p1 branch October 17, 2025 17:30
TimTaylor pushed a commit to TimTaylor/lintr that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants