Skip to content

Conversation

MichaelChirico
Copy link
Collaborator

Not an ideal benchmark, but with enough packages included this should give an idea of whether the linter is performing wildly differently between the branches

@AshesITR
Copy link
Collaborator

Good idea!
Would it be possible / useful to somehow export these timings in a structured way?
This could be used to quantitavely analyse the timing differences if they are obtained carefully (i.e. on the same idle system)

@MichaelChirico
Copy link
Collaborator Author

I think properly benchmarking the two branches is in scope for the script but would require a much bigger PR... filed this quickly as a first pass to give a rough idea (I don't expect it to work for, say, <30% performance difference, but something like 2x/3x should show up)

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Let's add a follow-up issue for that.

@AshesITR AshesITR merged commit 1aa166e into master Mar 11, 2021
@AshesITR AshesITR deleted the compare-timing branch March 11, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants