Retry prim_file:rename on eacces error #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, when creating a snapshot (renaming a checkpoint), occasionally prim_file:rename failed with `eacces`. It's not clear why this happens, it appears that Windows may not release the file handle immediately after closing the file so a close->rename in a quick succession may sometimes return an error. With this commit, we just retry after 20ms and so far, in our testing, the error has never occurred on the second attempt (with a 10ms delay, it still failed every now and then) We could have separate macros for eagain and eaccess, but I went with a share one. One retry seems reasonable in both cases.
kjnilsson
approved these changes
Jun 10, 2025
michaelklishin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jun 24, 2025
to include rabbitmq/ra#546.
mergify bot
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jun 24, 2025
to include rabbitmq/ra#546. (cherry picked from commit 4691a16)
michaelklishin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jun 25, 2025
to include rabbitmq/ra#546.
LoisSotoLopez
pushed a commit
to cloudamqp/rabbitmq-server
that referenced
this pull request
Jul 16, 2025
to include rabbitmq/ra#546.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when creating a snapshot (renaming a checkpoint), occasionally
prim_file:renamefailed witheacces. It's not clear why this happens, it appears that Windows may not release the file handle immediately after closing the file so a close->rename in a quick succession may sometimes return an error.With this commit, we just retry after 20ms and so far, in our testing, the error has never occurred on the second attempt (with a 10ms delay, it still failed every now and then)
We could have separate macros for eagain and eaccess, but I went with a shared one. One retry seems reasonable in both cases.