Skip to content

chore(function): substr function with optional argument #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

Make the substr function optionally accept the third argument. If the third argument is not given, the string is sliced from the start index to its length.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


Yes. Update the docs to reflect this change.

Make the substr function accept the third argument as optional. If the third argument is not given, the string is sliced from the start index to its length.
@rabbitstack rabbitstack added the scope: filters Anything related to filters label Jan 26, 2025
@rabbitstack rabbitstack changed the title chore(function): substr with optional argument chore(function): substr function with optional argument Jan 26, 2025
@rabbitstack rabbitstack merged commit ad606f0 into master Feb 15, 2025
6 checks passed
@rabbitstack rabbitstack deleted the substr-function-optional-argument branch February 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: filters Anything related to filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant