OpenStack::setTenant expects $tenant to be integer

[nickjenkin]

Currently, OpenStack::exportCreditentials exports the tenant id as a string. So when OpenStack::importCredientials calls setTenant with the output of exportCreditentials it fails to set the tenant correctly.

Change: if (is_int($tenant)) { to if (is_numeric($tenant)) {

(or fix exportCreds..)

[nickjenkin]

Also are there any unit tests around import/export creds? This is the second bug we have had relating to it and in both cases it meant that importCreds does not work at all.

[ycombinator]

Hi Nick,

We do have unit tests around importing and exporting credentials. Nevertheless I added another unit test to export credentials, import them and make sure the imported credentials match the original ones. Running this test, I was unable to reproduce the issue you mentioned with the string tenant ID.

Could you please let us know the following information?

• The version of PHP you are using,
• The version of php-opencloud you are using, and
• The tenant ID you are experiencing this problem with. Feel free to email this one to me at shaunak.kashyap@rackspace.com if you prefer.

[nickjenkin]

Your test should be importing the credentials into an unauthenticated client.

The behaviour we see is:

• import credentials into unautheticated client
• as tenant id is a string from exportCreds, the "is_int($tenant)" if call fails, and the else block with "$this->setTenantObject($identity->resource('Tenant', $tenant));" is executed. Something in this call sends an API request to rackspace, however the call gets an access denied error.

The fix we have on our end is:

$creds = $client->exportCredentials();
// fix for rackspace bug #290
$creds['tenant'] = (int)$creds['tenant'];
cache_set('rackspace.creds', $creds, 3600);

[nickjenkin]

Here is a dump of our client connect function:

function Client() {

    $user = api_key();

    $client = new Rackspace($user['endpoint'], array(
        'username' => $user['username'],
        'apiKey' => $user['api_key']
    ));

    if($creds = cache_get('rackspace.creds')) {

        $client->importCredentials($creds);

        if(!$client->hasExpired()) {
            return $client;
        }

    }

    $client->authenticate();
    $creds = $client->exportCredentials();
    // fix for rackspace bug #290
    $creds['tenant'] = (int)$creds['tenant'];

    cache_set('rackspace.creds', $creds, 3600);
    return $client;

}

[ycombinator]

Gotcha. Thanks for the detailed explanation. I'll make the fix to setTenant shortly.

[nickjenkin]

Thanks! It would be great if there was a high level test on import/export that tries to authenticate and execute a call on an unauthenticated client from the exportCreds of an existing client. The previous bug we had would also of been caught by such a test.

[ycombinator]

@jamiehannaford Do you have any thoughts on where to add the test suggested above? It doesn't feel like a unit test so I am hesitant to add it to test/OpenCloud/Tests/OpenStackTest.php.

[ycombinator]

@nickjenkin I've submitted a PR for the fix in setTenant and added a unit test to exercise the is_numeric code path in there as well. Once @jamiehannaford reviews my changes it will get merged into the master branch.

[jamiehannaford]

@nickjenkin Hey Nick, this should be fixed in the new release. If you continue to have issues, feel free to comment here and I'll reopen for investigation.