Add functions to enable / disable CDN Access Logs #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to actually unset the header to properly disable access logs.
Can't use saveMetadata() like Container.php because of the name of the header. Copied code from setStaticIndexPage()
jamiehannaford
pushed a commit
that referenced
this pull request
Nov 15, 2013
Add functions to enable / disable CDN Access Logs
|
@slashterix Hey Steven, this is great - thanks. There are a few mistakes which I can correct. To enable/disable logging for a normal container:
And for the CDN:
So to disable, you don't need to call |
jamiehannaford
added a commit
that referenced
this pull request
Nov 15, 2013
|
Ah OK. Ya the old code used the constant I can confirm you changes work great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
Replaces PR #224 (based on working instead of master)
Allows for enabling and disabling CDN Log Retention