Removing detail switch as the corresponding HTTP API call doesn't exist. #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamiehannaford, @gecampbell: Could you please review this when you have a couple of minutes? Thanks! |
|
🚢 it |
jamiehannaford
pushed a commit
that referenced
this pull request
Oct 23, 2014
Removing detail switch as the corresponding HTTP API call doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If these lines of code are to be believed, then a long time ago in a galaxy far, far away there apparently existed two HTTP API calls to retrieve a list of load balancers:
GET /v1.0/{tenantId}/loadbalancers, andGET /v1.0/{tenantId}/loadbalancers/detailThe API developer guide for Load Balancers, however, only documents call 1 but not call 2. Live HTTP requests against the load balancers service corroborate the documentation.
Unfortunately, as the
$detailparameter on theloadBalancerListmethod defaults totrue, the SDK defaults to making call 2 which results in an HTTP 404 response.This PR:
$detailparameter as deprecated.$detailargument, thereby preserving backwards compatibility in a reasonable manner (in my opinion).