Skip to content

Conversation

notFloran
Copy link
Contributor

No description provided.

@jamiehannaford
Copy link
Contributor

@notFloran Hey Floran - this is awesome, thanks for submitting a PR. I think returning a stdClass object should be fine here because an entire Diagnostics class would be overkill considering it's an outlying OS extension. @ycombinator, what do you think?

@notFloran
Copy link
Contributor Author

I use assertInternalType('object' and mock the response as suggested.

@ycombinator
Copy link
Contributor

LGTM too. Merging.

ycombinator added a commit that referenced this pull request Nov 19, 2014
Add method to get diagnostics for Server
@ycombinator ycombinator merged commit bd4162d into rackspace:working Nov 19, 2014
@notFloran notFloran deleted the diagnostics branch November 19, 2014 12:58
@ycombinator
Copy link
Contributor

Hi @notFloran, we would love to send you a little token of appreciation for your contributions to the SDK :) Could you please email your mailing address and t-shirt size to us at [email protected]? Thanks!

@notFloran
Copy link
Contributor Author

@ycombinator I sent an email. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants