Skip to content

Allow port update() to modify security groups. #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2015
Merged

Allow port update() to modify security groups. #602

merged 1 commit into from
May 20, 2015

Conversation

kaecyra
Copy link
Contributor

@kaecyra kaecyra commented May 19, 2015

Allows the \OpenCloud\Networking\Resource\Port::update() method to affect security groups, as per API and library documentation. Currently the 'securityGroups' option is silently ignored.

Additional keys are also omitted in the $updateKeys property, but they are beyond the scope of this pull-request:

adminStateUp
fixedIps
deviceOwner

@jamiehannaford
Copy link
Contributor

👍 LGTM

jamiehannaford pushed a commit that referenced this pull request May 20, 2015
Merge pull request #602 from kaecyra/fix-update-port-securitygroups
abe8163 
Allow port update() to modify security groups.
@jamiehannaford jamiehannaford merged commit abe8163 into rackspace:working May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaecyra @jamiehannaford