Skip to content

Conversation

konradpodgorski
Copy link
Contributor

I believe this does not require explaining :)

ps there are other issues in this class but I will make separate PRs once I get it running

I believe does not need explaining :)

ps there are other issues in this class but I will make separate PRs once I get it running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a slash before this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm...

@jamiehannaford
Copy link
Contributor

@konradpodgorski Cool! Thanks for submitting this. The linter seems to be complaining about the extra line; to fix, run:

./vendor/bin/php-cs-fixer fix --level psr2 lib/OpenCloud/Queues/Service.php

@konradpodgorski
Copy link
Contributor Author

@jamiehannaford hi. I think it complained because of order, not extra line (which in my opinion is more readable like this)

I ran php-cs-fixer but it didn't change anything

we will see in about minute

@konradpodgorski
Copy link
Contributor Author

@jamiehannaford ok, failed again

Running php-cs-fixer fix --dry-run --diff --level psr2 . locally with the same settings as in .travis does not throw anything

@jamiehannaford
Copy link
Contributor

@konradpodgorski hmm, when I run the syntax checker it replaces one of the lines with an almost identical version - so maybe it's an encoding issue?

› ./vendor/bin/php-cs-fixer fix --level psr2 lib/OpenCloud/Queues/Service.php
   1) /Users/jamie/projects/php/v1-sdk/lib/OpenCloud/Queues/Service.php
Fixed all files in 0.082 seconds, 5.250 MB memory used

› git diff
diff --git a/lib/OpenCloud/Queues/Service.php b/lib/OpenCloud/Queues/Service.php
index 27c6eb0..506555b 100644
--- a/lib/OpenCloud/Queues/Service.php
+++ b/lib/OpenCloud/Queues/Service.php
@@ -119,7 +119,7 @@ class Service extends CatalogService implements EventSubscriberInterface
      * Create a new Queue.
      *
      * @param string $name Name of the new queue
-     *
+     *
      * @throws InvalidArgumentError
      *
      * @return Queue

if you commit the above diff and re-push, does the build still break?

@jamiehannaford jamiehannaford merged commit 46bbbee into rackspace:working Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants