Linux 5.10.y: ethernet, wifi, leds, nvme and otg for Rock Pi 4C+

[marcone]

I noticed a recent network related update to the 4C+ dts in the 5.10.y branch, however with that change I still didn't get working ethernet or wifi. This set of patches remedies that. I've split them into 5 separate changes that:

• fix ethernet
• enable wifi
• add entries for both leds in /sys/class/leds
• enable NVME
• enable USB3 OTG

[RadxaNaoki]

I noticed a recent network related update to the 4C+ dts in the 5.10.y branch, however with that change I still didn't get working ethernet or wifi. This set of patches remedies that. I've split them into 5 separate changes that:

• fix ethernet
• enable wifi
• add entries for both leds in /sys/class/leds
• enable NVME
• enable USB3 OTG

thanks for updates.
about LEDs, please refer #20

[jack-ma]

arm64: dts: rockchip: enable Rock Pi 4C+ OTG
Rock Pi 4C+ is advertised as having one USB3 OTG port, so make it so.

4C+ doesn't have hw switch for the USB OTG, we must set the USB OTG as HOST by default, when the user want to use DEVICE function, he should configure it via dtbo from the OS.

[marcone]

configure it via dtbo from the OS

In the stable 4.4 branch and in the 4.4-based images that Radxa provides, OTG is configured by default in the main dtb, not in an overlay.

[jack-ma]

I believe @RadxaStephen should fix stable 4.4 branch as well. Without hardware switch, the port can not be called OTG, either HOST or DEVICE.

[marcone]

Either way seems fine, though changing the behavior now might affect upgrading users that rely on the existing behavior. For that reason it seems perhaps better to have "1 OTG + 1 host" be the default, and provide an overlay to make it 2 host ports.

[jack-ma]

This is how stable 4.4 branch do right now, an overlay to make HOST default.

[RadxaNaoki]

RK3399-T doesn't support PCIe. is NVMe working on your 4C+?

[marcone]

RK3399-T doesn't support PCIe. is NVMe working on your 4C+?

NVME works for me if I apply the corresponding change from this PR.

[jack-ma]

I think we can just leave the PCIe enabled. Some 4C+ v1.2 there on the market has M.2 because we tested it's working and the later 4C+ v1.4 removed because of no Rockchip official statement.

[marcone]

I think we can just leave the PCIe enabled. Some 4C+ v1.2 there on the market has M.2 because we tested it's working and the later 4C+ v1.4 removed because of no Rockchip official statement.

Do you mean current 4C+ boards don't have the M.2 slot on the board?

[jack-ma]

4C+ v1.2 has M.2 connector, 4C+ v1.4 and later doesn't have M.2 connector.

[carlfarrington]

For me, this works perfect with 5.19.10. Thanks @marcone. Without your version, very little worked.

I just had to add

&gpu {
	mali-supply = <&vdd_gpu>;
	status = "okay";
};

..for panfrost, which is working great BTW. sway and phoc (wayland) work fast and smooth.

and

&tsadc {
	status = "okay";
	rockchip,hw-tshut-mode = <1>;
	rockchip,hw-tshut-polarity = <1>;
};

..for temperature sensors

I did change the usbotg back to host though. I just want all 4 USB ports to work for peripherals.

[carlfarrington]

One last thing

I needed to change <&hdmi> and add in <&i2c3> in order for HDMI DDC to work properly with HDMI to DVI adapter.

&hdmi {
	ddc-i2c-bus = <&i2c3>;
	pinctrl-names = "default";
	pinctrl-0 = <&hdmi_cec>;
	status = "okay";
};

&i2c3 {
	i2c-scl-rising-time-ns = <450>;
	i2c-scl-falling-time-ns = <15>;
	status = "okay";
};

My notes from testing:
Seems like HDMI not working again. Seems to only be a problem on cold boot.
Works ok with direct HDMI cable. Not OK with HDMI to DVI adapter cable
Sometimes there's no framebuffer console
Sometimes there is framebuffer console, but then phoc starts in a weird resolution, doesn't seem to be able to identify monitor DDC data.
Testing <&hdmi> and <&i2c3> from rock-pi-4.dtsi instead:
works properly

[floion]

Hi @jack-ma @RadxaNaoki @RadxaStephen @RadxaYuntian can I ask you what is the state of this PR?

[RadxaYuntian]

This branch is no longer in use, as we now provide 5.10 kernel based on Rockchip linux-5.10-gen-rkr3.4 release.

[marcone]

@floion you might want to check out Armbian, which supports the 4C+ now and uses newer kernels.

[RadxaYuntian]

I'll close this for now, unless @floion has some dependency with our linux-5.10.y branch, and wants this merged.

@marcone , we have a mainline Linux based profile in our bsp tool, and our goal is to have @RadxaNaoki submit them to upstream. You are more than welcome to submit PR over there if some features is still broken.

[floion]

@RadxaYuntian so you have kernel 5.10 for the 4C / 4C+ on which branch of this bsp layer?

[floion]

thanks @marcone , we need to use this yocto bsp layer though

[RadxaYuntian]

We are currently supporting ROCK 4 series on linux-5.10-gen-rkr3.4 kernel branch. If you are asking about Yocto @RadxaStephen can answer that.

[floion]

Yes, I was asking about Yocto support for it. @RadxaStephen any insight?